👍 Looks GREAT To Me: Getting Past Bare Minimum Code Reviews - Adrienne Braganza Tacke

Learn effective code review practices, from managing PR size and writing objective feedback to establishing team agreements and leveraging automation tools to improve code quality.

Key takeaways
  • Leave ego at the door during code reviews - focus on the code, not the developer. Code reviews are not personal attacks but opportunities to improve the codebase.

  • Be your own first reviewer before submitting PRs - use automation, linting, testing and static analysis during development to catch basic issues early.

  • Keep PRs manageable and atomic - aim for under 500 lines of code per review. Split large features into smaller, focused parts that can be reviewed in 10-20 minutes.

  • Write effective, objective comments:

    • Use clear labels and be specific about what needs to change
    • Provide rationale for requested changes
    • Focus on the code, not the person
    • Use the “Request, Rationale, Result” pattern
  • Establish team working agreements for code reviews:

    • Define blocking vs non-blocking issues
    • Set PR size limits
    • Agree on review states and processes
    • Create PR templates with checklists
  • Take code reviews seriously with proper time allocation:

    • Review in 25-45 minute focused sessions
    • Don’t skim through changes
    • Give thorough consideration to changes
  • Move lengthy discussions offline but document outcomes in PR comments

  • Use automation and tooling:

    • Code owners files for automatic reviewer assignment
    • PR templates
    • Automated checks during development
  • Consider using informational reviewers to help spread knowledge and reduce siloing

  • Give code compliments when warranted - acknowledge good solutions and learning opportunities